Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(appservice)!: Rename virtual user to appservice user #1190

Merged
merged 1 commit into from
Nov 15, 2022
Merged

refactor(appservice)!: Rename virtual user to appservice user #1190

merged 1 commit into from
Nov 15, 2022

Conversation

johannescpk
Copy link
Contributor

@johannescpk johannescpk commented Nov 8, 2022 •
edited
Loading

Fixes #1109

Part of #228

@codecov
Copy link

codecov bot commented Nov 8, 2022 •
edited
Loading

Codecov Report

Base: 74.49% // Head: 73.55% // Decreases project coverage by -0.94% ⚠️

Coverage data is based on head (a84e6be) compared to base (882b206).
Patch coverage: 77.27% of modified lines in pull request are covered.

❗ Current head a84e6be differs from pull request most recent head 647760a. Consider uploading reports for the commit 647760a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1190      +/-   ##
==========================================
- Coverage   74.49%   73.55%   -0.95%     
==========================================
  Files         110      110              
  Lines       12834    12545     -289     
==========================================
- Hits         9561     9227     -334     
- Misses       3273     3318      +45
Impacted Files Coverage Δ
crates/matrix-sdk-appservice/src/user.rs 51.02% <0.00%> (ø)
crates/matrix-sdk-appservice/src/lib.rs 80.15% <80.95%> (-0.16%) ⬇️
crates/matrix-sdk/src/config/sync.rs 35.71% <0.00%> (-17.86%) ⬇️
crates/matrix-sdk-base/src/store/ambiguity_map.rs 84.70% <0.00%> (-12.95%) ⬇️
crates/matrix-sdk/src/room/invited.rs 70.58% <0.00%> (-12.75%) ⬇️
crates/matrix-sdk-base/src/rooms/members.rs 51.85% <0.00%> (-11.12%) ⬇️
crates/matrix-sdk/src/room/left.rs 90.90% <0.00%> (-9.10%) ⬇️
crates/matrix-sdk-base/src/client.rs 79.16% <0.00%> (-7.16%) ⬇️
...ates/matrix-sdk/src/room/timeline/event_handler.rs 66.83% <0.00%> (-5.86%) ⬇️
crates/matrix-sdk/src/client/login_builder.rs 19.67% <0.00%> (-5.74%) ⬇️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johannescpk johannescpk force-pushed the appservice/rename-virtual-user-to-appservice-user branch from a84e6be to 647760a Compare November 15, 2022 14:04
@jplatte jplatte enabled auto-merge (squash) November 15, 2022 14:47
@jplatte jplatte merged commit bb6cf83 into matrix-org:main Nov 15, 2022
@johannescpk johannescpk deleted the appservice/rename-virtual-user-to-appservice-user branch November 15, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

appservice: Rename virtual user to appservice user
2 participants
@johannescpk @jplatte